Repository navigation
Register Roster redirect domains - #17
Merged
jayjfletcher merged 27 commits intoOct 30, 2026
Merged
jayjfletcher merged 27 commits into
jayjfletcher merged 27 commits into
Conversation
…es slots and tab bar
…ed policy and owner-aware UI controller Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rch rule, test host and the no-Atrium proof Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ed policy and owner-aware UI controller Prefix the controller test's global helpers so they cannot clash with other test files loaded in the same Pest process. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mains on other packages' screens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tex's own screens and remove history UI (salvaged) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…mains on other packages' screens Retry: restore the testing environment before migrations roll back after the production case, and throw from the fixture policy only on the owned check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tex's own screens and remove history UI Forget scoped screen visibility before the viewAny list request in ScreenAccessClosureTest: the direct resolve() above it remembered a denial for the same request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Flush Atrium's screen registry before tests boot CortexServiceProvider a second time, since group 3 registers screens from boot() and Atrium refuses duplicates in testing. Tick groups 3 and 4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…CHANGELOG Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…CHANGELOG Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Scope the WithoutAtrium bootstrap guard to loaders that can reach Atrium, so Herd's prepended dump.phar loader no longer stops the suite, and sync the Ringside generated files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Drop Atrium's provider from testbench.yaml before Composer's scripts run testbench package:discover. - Apply ResetsScreenExtensions from tests/Pest.php, only when it exists: TestCase used it directly, and Pest loads TestCase for every suite. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jayjfletcher
deleted the
ring-master/2026-10-29-2038-register-roster-redirect-domains
branch
November 11, 2026 04:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk: high
What changed
src/Atrium/ScreenRegistrations.phpregisters acortex.mcptab orcortex.redirect-domainssection on screens named in the newcortex.atrium.redirect_domains.screensconfig (defaultroster.organizationtab,roster.useraside). It uses one shared view,ui/screens/redirect-domains.blade.php.RedirectDomainUiControllerstoreanddestroytake optionalowner_typeandowner_id, and redirect back only to a same-origin referrer.RedirectDomainPolicycreateanddeletefor owned domains now ask$user->can('update', $owner). This applies to the UI, the JSON API and MCP.Atrium\Screens::declare(), with the slots rendered in the views.require-devplussuggest, with aconflicton old versions.tests/WithoutAtriumsuite,phpunit.without-atrium.xml, a composer script and a CI job.Why
Roster's MCP redirect-domain UI belongs in Cortex, placed on any package's screens through config, with Cortex never naming Roster. Who may manage an owner's domains is decided by the owner's own policy (D-022, D-023, D-027). Other decisions that shaped the work:
conflict.Look at
src/Domains/RedirectDomain/Policies/RedirectDomainPolicy.php:37: the behaviour change forcreateanddelete. Guests and users withoutupdateon the owner are now refused over the API and MCP. A missing owner row fails closed.src/Atrium/ScreenRegistrations.php:137: thevisible()closure runs on every host render. Check that it queries nothing early and that a policy exception is swallowed.src/Atrium/Http/Controllers/RedirectDomainUiController.php:117: owner resolution (owner()), and the same-origin redirect inback()at line 140.composer.json:45: the Atriumconflictconstraint and therequiretorequire-devmove..github/workflows/tests.ymlandtests/WithoutAtrium/bootstrap.php: the CI lane is the authoritative no-Atrium proof.Tested
Gate round 2: PASS. phpstan and pint are clean, pest 828/828 passes with 100% coverage, and
test:without-atrium7/7 passes.ScreenRegistrationsTest,NoRosterReferenceTestVisibilityTestOwnedRedirectDomainsTestStylesTestRedirectDomainOwnerControllerTestOwnedRedirectDomainPolicyTestTestHostScreenTestDeclaredScreensTestScreenAccessClosureTestScreenLayoutTestNoHistoryUiTest,HistoryNavigationTestAuditTrailTestdeleted;RedirectDomainsTestsigns in a userComposerTest,ArchTestWithoutAtriumTest, plus the CI job (verified only by a workflow run)DocsTestRisks
updatepolicy now deny owned create and delete for API and MCP callers (CHANGELOG notes it).require-devbreaks apps that relied on Cortex pulling it in.conflictuses<1.0.0, so check the constraint at merge time.InvalidArgumentExceptiondeparts from theCortexExceptionconvention, and a row was added tostandards-feedback.md.without-atriumlane has not been run here.Merge order
Part of the screen-extensions group (D-009). Merge after Atrium Refactor-Circus/Atrium#16 and Keen Refactor-Circus/Keen#8, together with the Roster adopt-atrium-screen-registry PR (which removes Roster's inline redirect-domain UI; this PR registers it back onto
roster.organizationandroster.userfromconfig/cortex.php).composer.jsonconflicts withrefactor-circus/atrium<0.1.0.Breaks
The impact stage was not run.
$user->can('update', $owner). Null-owner domains are unchanged. Two existing tests inRedirectDomainsTestnow sign a user in before the owned calls.<x-atrium::audit-trail>andhistoryNavItem()drops the "Audit log" nav item. History now comes from Keen's wildcard section.composer testre-run green on the final branch: 828 tests plus 7 without-Atrium tests. Tested against the PR branches of Atrium, Keen and PennantPlus.Spec:
docs/agent/specs/2026-10-29-2038-register-roster-redirect-domains/🤖 Generated with Claude Code